From: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
---|---|
To: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
Cc: | Jim Mlodgenski <jimmy76(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
Subject: | Re: Custom Scan APIs (Re: Custom Plan node) |
Date: | 2013-11-28 21:12:04 |
Message-ID: | CADyhKSWFY-bfNwrF3zp3e9DvO03na2U4RyCo2uXKUb_vKetXjA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks for the series of checks.
The attached ones are the revised patches.
I merged all the propositions from Jim. Thanks, it made the documentation
quality better. Also, I fixed up cosmetic stuff around whitespace <-> tab.
An actual code changes are to follow the changes in FunctionScan when
CustomScan replaces a FunctionScan. It puts a List * object instead of
a single expression tree, to have multiple functions.
Nothing were changed from the previous version.
Best regards,
2013/11/27 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>:
> 2013/11/19 Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>:
>> OK, I split them off. The part-1 is custom-scan API itself, the part-2 is
>> ctidscan portion, and the part-3 is remote join on postgres_fdw.
>
> These three patches can be applied with no conflict onto 2013-11-27
> HEAD, but some fixes are necessary to build because commit
> 784e762e886e6f72f548da86a27cd2ead87dbd1c (committed on 2013-11-21)
> allows FunctionScan node to have multiple function expression, so Node
> * funcexpr in CustomScan should be List *funcitons now.
>
> I'll continue to review by applying patches onto 2013-11-19 HEAD.
>
> --
> Shigeru HANADA
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
Attachment | Content-Type | Size |
---|---|---|
pgsql-v9.4-custom-scan.part-3.patch | application/octet-stream | 62.0 KB |
pgsql-v9.4-custom-scan.part-2.patch | application/octet-stream | 51.2 KB |
pgsql-v9.4-custom-scan.part-1.patch | application/octet-stream | 62.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2013-11-28 21:19:15 | Re: Marginal performance improvement for fast-path locking |
Previous Message | Tom Lane | 2013-11-28 20:09:07 | Re: Marginal performance improvement for fast-path locking |