From: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [v9.2] DROP statement reworks |
Date: | 2011-09-28 15:51:40 |
Message-ID: | CADyhKSWCkJUyu213O3T10zAW2oOim9koCcA2Fc8qjOCeyCJBPg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/9/25 Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>:
> Hi,
>
> Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> writes:
>> 2011/8/15 Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>:
>>> The attached three patches try to consolidate code path of DROP
>>> statement on various kind of object classes.
>>
>> These are rebased to the latest tree, and the part-3 portion also consolidates
>> DROP OPERATOR FAMILY/CLASS routines that I forgot to rework in the
>> previous patch.
>
> I've been reviewing those patches, that are all about code refactoring.
> I like what it's doing, generalizing ad-hoc code by adding some more
> knowledge about the source tree into some data structures. Typically,
> what catcache to use for a given object's class-id.
>
> The patches are not in git am format nor in patch format, so I could
> only read them, I didn't install them nor compiled the code, didn't run
> the regression tests.
>
Thanks for your efforts.
I rebased the patches towards the latest git master, so I believe these
are available to apply.
Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
Attachment | Content-Type | Size |
---|---|---|
pgsql-v9.2-drop-reworks-1.v3.patch | application/octet-stream | 16.7 KB |
pgsql-v9.2-drop-reworks-2.v3.patch | application/octet-stream | 44.4 KB |
pgsql-v9.2-drop-reworks-3.v3.patch | application/octet-stream | 59.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2011-09-28 15:57:21 | Re: Extension proposal: www_fdw |
Previous Message | Andrew Dunstan | 2011-09-28 15:46:53 | Re: Feature proposal: www_fdw |