Re: [WIP] pg_ping utility

From: Phil Sorber <phil(at)omniti(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [WIP] pg_ping utility
Date: 2012-12-23 15:44:38
Message-ID: CADAkt-iyW2edwQKoVikDm+ASZUgaz1eX_UZUtpgUSoc7pjOzoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 23, 2012 at 10:07 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Sun, Dec 23, 2012 at 9:57 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> On Sun, December 23, 2012 15:29, Michael Paquier wrote:
>>>
>>> Once the 2 small things I noticed are fixed, this patch can be marked as
>>> ready for committer.
>>
>> I wasn't going to complain about it, but if we're going for small things anyway...
>>
>> The output is now capitalised:
>>
>> /tmp:6543 - Accepting Connections
>> /tmp:6000 - No Response
>>
>> which looks unusual to me, could we please make it all lower-case?
>
> I'm not apposed to it in principal. Is that how it is done elsewhere
> in the code? If there are no objections from anyone else I will roll
> that change in with the others.
>
>>
>>
>> TYhanks,
>>
>> Erik Rijkers
>>
>>
>>
>>
>>
>> --
>> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-hackers

Updated patch attached.

Attachment Content-Type Size
pg_isready_bin_v9.diff application/octet-stream 7.1 KB
pg_isready_docs_v9.diff application/octet-stream 7.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-12-23 17:38:02 Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Previous Message Fujii Masao 2012-12-23 15:24:00 Re: Feature Request: pg_replication_master()