| From: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logging WAL when updating hintbit |
| Date: | 2013-11-27 02:04:58 |
| Message-ID: | CAD21AoBNXDTYjGg9dEE4ic9cgOEf0FPBxPnAS7Puy4JVrgoQTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 27, 2013 at 2:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 11/25/13, 7:02 AM, Sawada Masahiko wrote:
>>> I attached the new version patch which adds separated parameter
>>> 'enable_logging_hintbit'.
>
>> Let's not add more parameters named enable_*. Every parameter enables
>> something.
>
> More to the point: there's a convention that we use enable_foo
> for planner control parameters that gate usage of a "foo" plan type.
> This is not in that category.
>
Thank you for feedback.
I attached the v4 patch which have modified. Just name changed to
'wal_log_hintbtis'.
And i'm also implementing documentation patch.
Regards,
-------
Sawada Masahiko
| Attachment | Content-Type | Size |
|---|---|---|
| log_hint_bit_wal_v4.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-11-27 02:22:11 | Re: Logging WAL when updating hintbit |
| Previous Message | Tom Lane | 2013-11-27 01:30:01 | Re: lock on object is already held |