Re: The number of character limitation of custom script on pgbench

From: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The number of character limitation of custom script on pgbench
Date: 2013-11-15 11:47:38
Message-ID: CAD21AoAVr4P++=RXuZoJiHr8FX_3AQKteMjD5d79YKB++JWjdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 13, 2013 at 10:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 11/13/13, 6:18 AM, Sawada Masahiko wrote:
>>> The function of custom script of pgbench allows only BUFSIZ
>>> (i.g.,1024byte) or less as length of a SQL.
>>> So I'm thinking following solution.
>>> (1) to increase buffer size
>>> (2) to change to variable buffer size
>>> (3) to return ERROR with information
>
>> I'd go for #2. But at least an error.
>
> #2 definitely. I've run into this limitation myself recently, and
> so have other people. It's time to fix it.
>

I attached the patch which solves this problem, and have submitted to CF3.
I changed how to get the SQL from custom script file.

Regards,

-------
Sawada Masahiko

Attachment Content-Type Size
fix_limitaion_custom_script_pgbench.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-11-15 11:51:28 Re: Proof of concept: standalone backend with full FE/BE protocol
Previous Message Haribabu kommi 2013-11-15 11:10:30 Re: New option for pg_basebackup, to specify a different directory for pg_xlog