Re: [PATCH] introduce XLogLockBlockRangeForCleanup()

From: Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com>
To: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Date: 2014-07-07 08:32:15
Message-ID: CACoZds2nbjNUBBJ4vo0fepS+NVBAhYLfK5NZNiUa3PBr2-bmWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4 July 2014 19:11, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> wrote:

> Updated patch attached, thanks.
>
> Amit: what's your conclusion from the review?
>

Other than some minor comments as mentioned below, I don't have any more
issues, it looks all good.

XLogLockBlockRangeForCleanup() function header comments has the function
name spelled: XLogBlockRangeForCleanup

In GetBufferWithoutRelcache(), we can call BufferDescriptorGetBuffer(buf)
rather than BufferDescriptorGetBuffer(&BufferDescriptors[buf_id]).

> -- Abhijit
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2014-07-07 08:46:09 Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Previous Message Jeff Davis 2014-07-07 08:21:09 Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls