Re: Function array_agg(array)

From: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Function array_agg(array)
Date: 2014-10-27 10:20:43
Message-ID: CACQjQLqcPkKUUKiZFeyPn6uO0UnJCa-Rx5gx+2Lz07diGN7quw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-10-27 16:15 GMT+07:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:

> Hi
>
> I did some minor changes in code
>
> * move tests of old or new builder style for array sublink out of main
> cycles
> * some API simplification of new builder - we should not to create
> identical API, mainly it has no sense
>

minor changes in the patch:
* remove array_agg_finalfn_internal declaration in top of array_userfuncs.c
* fix comment of makeMdArray
* fix return of makeMdArray
* remove unnecesary changes to array_agg_finalfn

Regards,
--
Ali Akbar

Attachment Content-Type Size
array_agg_anyarray-13.patch text/x-patch 29.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2014-10-27 10:37:34 Re: Better support of exported snapshots with pg_dump
Previous Message Pavel Stehule 2014-10-27 10:05:11 Re: strip nulls functions for json and jsonb