| From: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode |
| Date: | 2014-01-29 15:59:41 |
| Message-ID: | CAB8KJ=gKJm1xx6SVZrRcrjNGm3Do9CMC81z49ny52L5FGzSm6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2014/1/29 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
> 2014-01-29 Andrew Dunstan <andrew(at)dunslane(dot)net>:
>>
>> On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
>>>
>>>
>>> Hi Payal
>>>
>>> Many thanks for the review, and my apologies for not getting back to
>>> you earlier.
>>>
>>> Updated version of the patch attached with suggested corrections.
>>
>> On a very quick glance, I see that you have still not made adjustments to
>> contrib/file_fdw to accommodate this new option. I don't see why this COPY
>> option should be different in that respect.
>
> Hmm, that idea seems to have escaped me completely. I'll get onto it forthwith.
Striking while the keyboard is hot... version with contrib/file_fdw
modifications
attached.
Regards
Ian Barwick
| Attachment | Content-Type | Size |
|---|---|---|
| copy-force-null-v3.patch | text/x-patch | 24.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steeve Lennmark | 2014-01-29 17:07:06 | Re: [PATCH] Relocation of tablespaces in pg_basebackup |
| Previous Message | Andrew Dunstan | 2014-01-29 15:44:47 | Re: jsonb generation functions |