Re: Add generate_series(numeric, numeric)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Платон Малюгин <malugin(dot)p(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add generate_series(numeric, numeric)
Date: 2014-09-30 01:01:22
Message-ID: CAB7nPqSpV7W9r3DoUDm=yF+kPgz5TVhrwD4GU43CAqtskGPULQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 30, 2014 at 10:00 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> wrote:

>
>
> On Mon, Sep 29, 2014 at 4:19 PM, Michael Paquier <
> michael(dot)paquier(at)gmail(dot)com> wrote:
>
>>
>> Michael
>> Btw, while looking at your patch, I actually hacked it a bit and finished
>> with the attached:
>> - changed process to use NumericVar instead of Numeric
>> - addition of custom step values with a function
>> generate_series(numeric,numeric,numeric)
>> - some cleanup and some comments here and there
>> That's still WIP, but feel free to use it for future work. If you are
>> able to add documentation and regression tests to this patch, I would
>> recommend that you register it to the next commit fest, where it would get
>> more review, and hopefully it will get committed.
>>
> Oops, it seems that I have been too hasty here. With a fresh mind I looked
> at my own patch again and found two bugs:
> - Incorrect initialization of step variable with const_one
> - Incorrect calculation of each step's value, making stuff crash, it is
> necessary to switch to the context of the function to perform operations on
> a temporary variable first.
>
And here is the patch...
--
Michael

Attachment Content-Type Size
20140930_generate_series_numeric.patch text/x-diff 5.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-09-30 01:40:28 Upcoming Postgres 9.4beta3 release
Previous Message Michael Paquier 2014-09-30 01:00:40 Re: Add generate_series(numeric, numeric)