| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <jim(at)nasby(dot)net> |
| Subject: | Re: CREATE TABLESPACE WITH |
| Date: | 2014-01-18 14:21:13 |
| Message-ID: | CAB7nPqRpWyuiVnbwcLh+CXUt=cev-Yn8DJ8y=_67pzv0X6nGvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 16, 2014 at 9:03 AM, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> wrote:
> New patch attached, with regression tests.
Thanks for the new version, I have spent some time looking at it:
- Patch compiles without warnings.
- Done some manual testing with CREATE/ALTER TABLESPACE WITH and
checked pg_tablespace, it worked fine.
- However, regression tests are failing because
src/test/regress/output/tablespace.source has an incorrect output, it
is necessary to replace that:
/home/vik/postgresql/9.4/git/src/test/regress/testtablespace
by that:
@testtablespace@
This is something I have actually fixed that in the attached patch.
So, except for the regression output problem, I think that the code is
clean so marking it as "Ready for committer" on the commit fest app.
Thanks,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20140118_create_tablespace_with_v4.patch | text/x-diff | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2014-01-18 14:22:10 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Previous Message | Andrew Dunstan | 2014-01-18 14:14:02 | Re: currawong is not a happy animal |