Re: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alexey Vasiliev <leopard_ne(at)inbox(dot)ru>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Date: 2014-12-22 03:07:06
Message-ID: CAB7nPqRUJWh5j4BbUr2nnmjhzoPoZLhJ4TU8PrJ29SctBxO=9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 4, 2014 at 6:25 AM, Alexey Vasiliev <leopard_ne(at)inbox(dot)ru> wrote:
> Added new patch.
Seems useful to me to be able to tune this interval of time.

I would simply reword the documentation as follows:
If <varname>restore_command</> returns nonzero exit status code, retry
command after the interval of time specified by this parameter.
Default value is <literal>5s</>.

Also, I think that it would be a good idea to error out if this
parameter has a value of let's say, less than 1s instead of doing a
check for a positive value in the waiting latch. On top of that, the
default value of restore_command_retry_interval should be 5000 and not
0 to simplify the code.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-12-22 03:19:07 Re: [PATCH] Add transforms feature
Previous Message Fabrízio de Royes Mello 2014-12-22 02:55:14 Re: Proposal "VACUUM SCHEMA"