Re: Support for REINDEX CONCURRENTLY

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Support for REINDEX CONCURRENTLY
Date: 2013-03-09 04:31:28
Message-ID: CAB7nPqQwNAYvEucbtoTWPj2eGWf=hQ0eJY=7HkyCvyVQkHfrzQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 9, 2013 at 1:37 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> + <para>
> + Concurrent indexes based on a <literal>PRIMARY KEY</> or an
> <literal>
> + EXCLUSION</> constraint need to be dropped with <literal>ALTER
> TABLE
>
> Typo: s/EXCLUSION/EXCLUDE
>
Thanks. This is corrected.

> I encountered a segmentation fault when I ran REINDEX CONCURRENTLY.
> The test case to reproduce the segmentation fault is:
>
> 1. Install btree_gist
> 2. Run btree_gist's regression test (i.e., make installcheck)
> 3. Log in contrib_regression database after the regression test
> 4. Execute REINDEX TABLE CONCURRENTLY moneytmp
>
Oops. I simply forgot to take into account the case of system attributes
when building column names in index_concurrent_create. Fixed in new version
attached.

Regards,
--
Michael

Attachment Content-Type Size
20130309_1_remove_reltoastidxid_v4.patch application/octet-stream 39.1 KB
20130309_2_reindex_concurrently_v22.patch application/octet-stream 80.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-03-09 04:35:28 Re: Request for vote to move forward with recovery.conf overhaul
Previous Message Greg Smith 2013-03-09 04:20:54 Re: Request for vote to move forward with recovery.conf overhaul