On Mon, Jun 16, 2014 at 12:19 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> wrote:
> On Fri, Jun 13, 2014 at 4:14 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > A couple of things to note though:
> > 1) In order to detect if a page is used for a sequence, SEQ_MAGIC
> > needs to be exposed in sequence.h. This is included in the patch
> > attached but perhaps this should be changed as a separate patch
> > 2) Regression test facility uses some useful parts taken from
> > pg_upgrade. I think that we should gather those parts in a common
> > place (contrib/common?). This can facilitate the integration of other
> > modules using regression based on bash scripts.
> > 3) While hacking this facility, I noticed that some ItemId entries in
> > btree pages could be inconsistent between master and standby. Those
> > items are masked in the current patch, but it looks like a bug of
> > Postgres itself.
> Attached are 3 patches doing exactly this separation for lisibility.
>
Here are rebased patches, their was a conflict with a recent commit in
contrib/pg_upgrade.
--
Michael