Postgres ReviewFest Patch: URI connection string support for libpq

From: Nick Roosevelt <nroose(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Postgres ReviewFest Patch: URI connection string support for libpq
Date: 2012-01-13 04:07:04
Message-ID: CAAyg8k0KxT6xa2ADcZwJzBTdR-BeE1tN_UKbt24HvCaL3VvGig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Just reviewed the patch for adding URI connection string support for libpg.

There seem to be many tabs in the patch. Perhaps the indentation is not
correct.

Also, the patch did not run correctly:

patching file src/interfaces/libpq/fe-connect.c
Hunk #1 succeeded at 282 with fuzz 1.
Hunk #2 FAILED at 300.
Hunk #3 FAILED at 583.
Hunk #4 FAILED at 3742.
Hunk #5 FAILED at 4132.
Hunk #6 FAILED at 4279.
Hunk #7 FAILED at 4455.
6 out of 7 hunks FAILED -- saving rejects to file
src/interfaces/libpq/fe-connect.c.rej

Seems like the file has changed since this patch was created. Please
recreate the patch.

Thanks,

Nick Roosevelt

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-01-13 04:18:40 Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Previous Message Fujii Masao 2012-01-13 03:58:32 Re: log messages for archive recovery progress