From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: option -T in pg_basebackup doesn't work on windows |
Date: | 2014-08-21 10:14:42 |
Message-ID: | CAA4eK1L41oGcSUDoEXoFkajUb0oGtARckpTOGWXQHBP5pZiq=w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas <
hlinnakangas(at)vmware(dot)com> wrote:
> >Wouldn't it make a lot more sense to create it correctly in the first
place?
>
> Looking at the code, I think it is very well possible to create
> it correctly in the first place without much extra work. I will
> send a patch if nobody sees any problem with this change.
Attached patch implements the above suggested fix.
I have removed the earlier code which was used to update the
symlink path.
Do you see any need to change below line in docs:
"If a tablespace is relocated in this way, the symbolic links inside the
main data directory are updated to point to the new location."
Refer link:
http://www.postgresql.org/docs/devel/static/app-pgbasebackup.html
I was not sure whether docs need any change, so kept them
intact.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
pg_basebackup_relocate_tablespace_v3.patch | application/octet-stream | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-08-21 10:19:25 | Re: plpgsql.extra_warnings='num_into_expressions' |
Previous Message | Fabien COELHO | 2014-08-21 09:53:33 | Re: documentation update for doc/src/sgml/func.sgml |