From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Finer Extension dependencies |
Date: | 2012-03-08 13:17:43 |
Message-ID: | CA+TgmobzG0js1a-d8=fHuNRVHR_x5DCnfo+pd3-khqgmO=Ci5w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 28, 2012 at 5:34 AM, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> wrote:
> Quickly reviewed the patch and found some issues.
>
> - There are some mixture of pg_extension_feature and pg_extension_feature"s"
> - The doc says pg_extension_feature"s" has four columns but it's not true.
> - Line 608 is bad. In the loop, provides_itself is repeatedly changed
> to true and false and I guess that's not what you meant.
> - Line 854+, you can fold two blocks into one. The two blocks are
> similar and by giving provides list with list_make1 when
> control->provides == NIL you can do it in one block.
> - s/trak/track/
> - Line 960, you missed updating classId for dependency.
>
> That's pretty much from me. I just looked at the patch and have no
> idea about grand architecture. Marking Waiting on Author.
Dimitri, are you going to post an updated patch for this CF?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-03-08 13:20:02 | Re: Avoiding shutdown checkpoint at failover |
Previous Message | Robert Haas | 2012-03-08 13:15:35 | Re: Inline Extension |