| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [v9.2] make_greater_string() does not return a string in some cases |
| Date: | 2011-10-07 16:25:08 |
| Message-ID: | CA+Tgmoao2OoZBMUsfp3ZC0_LgXsv3jBvY9eYR5h+cZYez7j26Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Oct 7, 2011 at 12:22 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> Thank you for reviewing.
>
> The new version of this patch is attached to this message.
OK, I think this is reasonably close to being committable now. There
are a few remaining style and grammar mistakes but I can fix those up
before committing. One thing I still think it would be useful to add,
though, is some comments to pg_utf8_increment() and
pg_eucjp_increment() describing the algorithm being used. Can you
take a crack at that?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe | 2011-10-07 21:51:08 | BUG #6245: one click Installer problem |
| Previous Message | Merlin Moncure | 2011-10-07 15:41:30 | Re: BUG #6244: Ordering Problem |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2011-10-07 16:34:46 | Re: PQsendQuery/ PQgetResult Problem |
| Previous Message | Usama Dar | 2011-10-07 16:17:22 | PQsendQuery/ PQgetResult Problem |