| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: plpgsql.print_strict_params |
| Date: | 2013-10-03 16:55:39 |
| Message-ID: | CA+Tgmoa=7s4_+S8h7MfHMK6aHjFPdQW-BUQo0aHz6N04E=4BTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 28, 2013 at 8:42 AM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> On 2013-09-28 12:31, Ian Lawrence Barwick wrote:
>> The patch looks good to me now; does the status need to be changed to
>> "Ready for Committer"?
>
> Yes.
>
> Thanks for reviewing!
This looks like a nice clean patch. My only concern is that it makes
"on" and "off" unreserved plpgsql keywords. It looks like that will
make them unusable as unquoted identifiers in a few contexts in which
they can now be used. Has there been any discussion about whether
that's OK?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steve Singer | 2013-10-03 17:03:07 | Re: logical changeset generation v6.2 |
| Previous Message | Andres Freund | 2013-10-03 16:38:59 | Re: logical changeset generation v6.2 |