Unwanted LOG during recovery of DROP TABLESPACE REDO

From: Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Unwanted LOG during recovery of DROP TABLESPACE REDO
Date: 2014-07-16 05:59:45
Message-ID: BF2827DCCE55594C8D7A8F7FFD3AB7713DE171CC@SZXEML508-MBX.china.huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I found and fixed a bug that causes recovery (crash recovery , PITR) to throw unwanted LOG message if the tablespace symlink is not found during the processing of DROP TABLESPACE redo.
LOG: could not remove symbolic link "pg_tblspc/16384": No such file or directory

To Reproduce the issue:

1. Start the server.

2. Create a tablespace.

3. Perform Checkpoint.

4. Drop tablespace.

5. Stop server using immediate mode.

6. Start server : At this stage, recovery throw log message as mentioned above.

Reason is that DROP TABLESPACE has already removed symlink and again it is being tried to remove during recovery.
As it is very much possible that DROP TABLESPACE was successful and cleaned up the file before server crashed. So this should be considered as valid scenario and no need to throw
any LOG in such case. In case of processing of CREATE TABLESPACE redo, same is already handled.

I will add this to 2014-08 CF for review.

Thanks and Regards,
Kumar Rajeev Rastogi

Attachment Content-Type Size
rec_issue_with_drop_tblspc_redo.patch application/octet-stream 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-07-16 06:26:25 Re: Bug in spg_range_quad_inner_consistent for adjacent operator (was Re: Add a filed to PageHeaderData)
Previous Message Michael Paquier 2014-07-16 05:30:24 Re: Bug in spg_range_quad_inner_consistent for adjacent operator (was Re: Add a filed to PageHeaderData)