PATCH: make plpgsql IN args mutable (v1)

From: Steve Prentice <prentice(at)cisco(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: PATCH: make plpgsql IN args mutable (v1)
Date: 2009-07-30 20:37:16
Message-ID: BBE2C567-4995-4229-A811-0012FC263510@cisco.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Since I didn't get completely shot out of the water and a couple
people seemed to think it was helpful, I'm submitting this patch for
consideration in the next commitfest.

This patch changes plpgsql IN parameters so they are mutable.
Previously, they were being forced constant. This patch modifies the
plpgsql.sql regression test and corresponding .out file. The
regression test also makes sure the passed in parameter does not get
changed in the calling function.

I decided not to update the docs for this change because the docs
don't currently indicate that an IN parameter is constant and I didn't
want to encourage it because it isn't universally considered good
programming practice to assign to an IN parameter. If others think we
need a doc change for this, I'll update the patch.

The following function will compile with this patch:

create or replace function param_assign_test(a int, val int)
returns void as $$
begin
a := val;
end
$$ language plpgsql;

This function would have failed to compile previously.

-Steve

Attachment Content-Type Size
plpgsql_in_args_mutable-v1.diff application/octet-stream 2.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-07-30 21:06:17 Re: PATCH: make plpgsql IN args mutable (v1)
Previous Message Tom Lane 2009-07-30 20:03:26 Re: improvements for dict_xsyn extended synonym dictionary - RRR