Re: patch: Allow \dd to show constraint comments

I checked the v4 patch.

At first, I noticed three missing object classes although COMMENT ON allows to
set a description on 'collation', 'extension' and 'foreign table'.
In addition, this pg_comments system view supports 'access method' class, but
we cannot set a comment on access methods using COMMENT ON statement.

Regarding to the data-type of objnamespace, how about an idea to define a new
data type such as 'regschema' and cast objnamespace into this type?
If we have such data type, user can reference string expression of schema name,
and also available to use OID joins.

Thanks,

2011/6/5 Josh Kupershmidt <schmiddy(at)gmail(dot)com>:
> On Tue, May 24, 2011 at 10:31 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
>> Attached is a rebased patch. From a quick look, it seems that most of
>> the object types missing from \dd are already covered by pg_comments
>> (cast, constraint, conversion, domain, language, operator class,
>> operator family). A few objects would probably still need to be added
>> (foreign data wrapper, server).
>
> Here's another update to this patch. Includes:
>  * rudimentary doc page for pg_comments
>  * 'foreign data wrapper' and 'server' comment types now included in
> pg_comments; regression test updated
>
> Still TODO:
>  * psql's \dd should read from pg_comments. But I think we need some
> simple way to distinguish comments on system objects from non-system
> objects, which we'd need for differentiating \dd from \ddS, not to
> mention being useful for ad-hoc queries. I'm open to ideas here.
>
> Josh
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>

--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>