psql describe.c cleanup

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: psql describe.c cleanup
Date: 2011-05-07 19:40:35
Message-ID: BANLkTimXY3xdz7bdhWnHF2BTd2vcKPBTaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I use psql's -E mode every now and then, copy-and-pasting and further
tweaking the SQL displayed. Most queries are displayed terminated by a
semicolon, but quite a few aren't, making copy-and-paste just a bit
more tedious.

Attached is a patch to fix every SQL query I saw in describe.c. There
were also a few queries with trailing newlines, and I fixed those too.

And while I'm griping about describe.c, is it just me or is the source
code indentation in that file totally screwy? I'm using emacs and I've
loaded the snippet for pgsql-c-mode from
./src/tools/editors/emacs.samples into my ~/.emacs, but the
indentation of multiline strings still looks inconsistent. See
attached screenshot, e.g. the start of line 80 has four tabs and one
space, while line 79 has six tabs and two spaces?

Josh

Attachment Content-Type Size
psql_describe.v2.patch text/x-patch 16.4 KB
image/png 33.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-05-07 19:43:40 Re: Fix for pg_upgrade user flag
Previous Message Bruce Momjian 2011-05-07 19:29:28 Re: Bug in autovacuum.c?