| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Subject: | Re: patch (for 9.1) string functions |
| Date: | 2010-07-21 03:27:00 |
| Message-ID: | AANLkTimuv9Rxu1cRQwQa4pO4Av9kAIwUrW-LzQ8IlZrf@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I reviewed the core changes of the patch. I don't think we need
mb_string_info() at all. Instead, we can just call pg_mbxxx() functions.
I rewrote the patch to use pg_mbstrlen_with_len() and pg_mbcharcliplen().
What do you think the changes? It requires re-counting lengths of multi-byte
strings in some cases, but the code will be much simpler and can avoid
allocating length buffers.
I'd like to apply contrib/stringinfo apart from the core changes,
because there seems to be still some idea to improve sprintf().
--
Itagaki Takahiro
| Attachment | Content-Type | Size |
|---|---|---|
| stringfunc_core-20100721.diff | application/octet-stream | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2010-07-21 04:39:33 | Re: patch: to_string, to_array functions |
| Previous Message | Fujii Masao | 2010-07-21 03:25:15 | Fwd: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby |