| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Extensions, this time with a patch |
| Date: | 2010-11-22 01:10:05 |
| Message-ID: | AANLkTimVFhCHNZ2SQtHu-jfs-zj4nUwYPCn8d_pVVrEz@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 20, 2010 at 01:36, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Ah yes, thinking it's an easy patch is not helping. Please find attached
> a revised version of it.
I checked cfparser.v2.patch.
It exports the static parseRecoveryCommandFileLine() in xlog.c
as the global cfParseOneLine() in cfparser.c without modification.
It generates one warning, but it can be easily fixed.
cfparser.c:34: warning: no previous prototype for 'cfParseOneLine'
Some discussions about the patch:
* Is "cf" the best name for the prefix? Less abbreviated forms might
be less confusable. Personally, I prefer "conf".
* Can we export ParseConfigFile() in guc-file.l rather than
parseRecoveryCommandFileLine()? It can solve the issue that unquoted
parameter values in recovery.conf are not recognized. Even if we
won't merge them, just allowing unquoted values would be useful.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Kupershmidt | 2010-11-22 01:18:30 | psql: Add \dL to show languages |
| Previous Message | Alvaro Herrera | 2010-11-22 00:39:38 | Re: Re: Mailing list archives |