| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Leonardo Francalanci <m_lists(at)yahoo(dot)it> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Date: | 2010-08-31 11:04:19 |
| Message-ID: | AANLkTikr_S9BT8d79bv5MS3tEtJTXwPNG87-wKdAseQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sorry for the very delayed review.
On Wed, Jul 21, 2010 at 11:15 PM, Leonardo Francalanci <m_lists(at)yahoo(dot)it> wrote:
> 2) what other areas can I comment more?
I think the patch is almost ready to commit, but still
have some comments for the usability and documentations.
I hope native English speakers would help improving docs.
* Documentation could be a bit more simplified like as
"CLUSTER requires twice disk spaces of your original table".
The added description seems too difficult for standard users.
* How to determine which method was used?
We can get some information from trace_sort logs,
but CLUSTER VERBOSE would be better to log
which CLUSTER method was used.
* How to control which method will be used?
It might be good to explain we can control the method
with enable_seqscan/indexscan.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-08-31 11:21:38 | Re: Git conversion progress report and call for testing assistance |
| Previous Message | Fujii Masao | 2010-08-31 10:40:10 | Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!) |