From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
---|---|
To: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: log files and permissions |
Date: | 2010-07-13 05:18:00 |
Message-ID: | AANLkTikiiKM2_Pz66U9rarkD4MJdDBnpL1O3K-i5fIiE@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I think the patch is almost ready for committer except the following
three issues:
2010/7/13 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
>> + if (!*value || *endptr || file_mode < 0 || file_mode > 0777)
> The sticky bit cannot be set via log_file_mode. Is this intentional?
We should also check the value not to be something like 0699.
How about checking it with (file_mode & ~0666) != 0 ?
>> +#ifndef WIN32
>> + chmod(filename, Log_file_mode);
>> +#endif
> Don't we need to check the return value of chmod()?
I prefer umask() rather than chmod() here.
>> +const char *show_log_file_mode(void);
> You forgot to write the show_log_file_mode()? I was not able to find that
> in the patch.
I want show_log_file_mode to print the setting value in octal format.
--
Itagaki Takahiro
From | Date | Subject | |
---|---|---|---|
Next Message | Itagaki Takahiro | 2010-07-13 06:50:54 | Re: patch (for 9.1) string functions |
Previous Message | Tom Lane | 2010-07-13 04:25:52 | Re: dblink regression failure in HEAD |