| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multiset patch review |
| Date: | 2011-02-15 12:13:21 |
| Message-ID: | AANLkTikU_AX+v1FoTrmiHuO8F=X9iekSDRAGTBGhnVmB@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 15, 2011 at 4:31 AM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> array_flatten() no longer exists. I added array_trim() as an alias
> to trim_array() because it would be a FAQ.
I don't like the alias thing - let's add one name or the other, not both.
Similarly, let's NOT add array_union_all as an alias for array_concat.
'cannot use multi-dimensional arrays' reads awkwardly to me. I think
it should say something like "sorting of multi-dimensional arrays is
not supported".
multi-demensional -> multi-dimensional
slaces -> slices
The formula in the trim_array comment is apparently misparenthesized.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-02-15 12:41:37 | Re: Change pg_last_xlog_receive_location not to move backwards |
| Previous Message | Robert Haas | 2011-02-15 11:55:52 | Re: CommitFest 2011-01 as of 2011-02-04 |