| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: top-level DML under CTEs |
| Date: | 2010-10-05 12:37:52 |
| Message-ID: | AANLkTik1JCag5X6mOc+4pxFeZ03otyHyOjvEN_RAmrhp@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2010/10/5 Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
> (Oops, this didn't go to -HACKERS)
>
> On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
>>
>> (HEAD from git://git.postgresql.org/git/postgresql.git)
>>
>> The patch applies only with error.
>> If that error is ignored, the regression 'with' test failes.
>> If that is also ignored, it runs.
>
> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
> patch just a bit and it now passes all regression tests so I can review
> it. New version attached for documentation purposes.
Thank you, I didn't notice that commit. In your last patch, the
snippet to add errhint() and ref/insert sgml is unnecessary since it
was for INSERT ... VALUES fix.
Regards,
--
Hitoshi Harada
| Attachment | Content-Type | Size |
|---|---|---|
| toplevel-dml-cte.20101005.diff | application/octet-stream | 18.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-10-05 12:56:14 | Re: ALTER DATABASE RENAME with HS/SR |
| Previous Message | Craig Ringer | 2010-10-05 12:36:24 | A quick warning on the win32 build scripts |