| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Include WAL in base backup |
| Date: | 2011-01-25 20:17:16 |
| Message-ID: | AANLkTik+uhk8BUd2JKGxKhCLtiLi3GQP9T4wEfWxg7rd@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 25, 2011 at 16:34, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Jan 25, 2011 at 15:04, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Tue, Jan 25, 2011 at 10:28 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>> (the discussed changse above have been applied and pushed to github)
>>>
>>> Thanks! I'll test and review that.
>>
>> WAL file might get recycled or removed while walsender is reading it.
>> So the WAL file which pg_basebackup seemingly received successfully
>> might be actually invalid. Shouldn't we need to check that what we read
>> is valid as XLogRead does?
We should, and the easiest way is to actually use XLogRead() since the
code is already there. How about the way in this patch?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| basebackup_wal.patch | text/x-patch | 15.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-25 20:31:59 | Re: Patch to add a primary key using an existing index |
| Previous Message | Kevin Grittner | 2011-01-25 20:01:54 | Re: SSI, simplified |