Patch: add GiST support for BOX @> POINT queries

From: Andrew Tipton <andrew(dot)t(dot)tipton(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Patch: add GiST support for BOX @> POINT queries
Date: 2011-02-23 23:05:40
Message-ID: AANLkTi=MwZ_UpJ7Kp572fYJ_=vr98bgvcRP8cRmzdvNP@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While playing around with the BOX and POINT datatypes, I was surprised to
note that BOX @> POINT (and likewise POINT <@ BOX) queries were not using
the GiST index I had created on the BOX column. The attached patch adds a
new strategy @>(BOX,POINT) to the box_ops opclass. Internally,
gist_box_consistent simply transforms the POINT into its corresponding BOX.

This is my first Postgres patch, and I wasn't able to figure out how to go
about creating a regression test for this change. (All existing tests do
pass, but none of them seem to specifically test index behaviour.)

I know it is quite late in the CommitFest, should I add this to CF-Next?

-Andrew

Attachment Content-Type Size
gist-boxpoint-support.patch text/x-patch 1.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-02-23 23:12:56 Re: Patch: add GiST support for BOX @> POINT queries
Previous Message Marko Tiikkaja 2011-02-23 22:48:38 Re: Review: Fix snapshot taking inconsistencies