Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Asif Naeem" <anaeem(dot)it(at)gmail(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation
Date: 2014-03-25 12:09:13
Message-ID: 994F3C8171ED42D7898F0795DCD6ACAA@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
> If you think that above scenario is not possible, then you just need to
> modify comment:
> "! * Remove old symlink in recovery...."

Hm, my scenario seems impossible. I reverted the comment.

> One more minor point about patch:
> + struct stat st;
>
> if (InRecovery)
> {
> struct stat st;
>
> Defining stat struct two times in same function in different ways doesn't
> seem to be good, we can do the same way for new usage as is already
> done in code or may be declare it once.

OK, I removed the second (existing) definition of st.

Regards
MauMau

Attachment Content-Type Size
remove_tblspc_symlink_v6.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2014-03-25 12:48:04 Re: inherit support for foreign tables
Previous Message Alvaro Herrera 2014-03-25 12:03:22 Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG