Re: proposal: new long psql parameter --on-error-stop

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: new long psql parameter --on-error-stop
Date: 2014-06-21 13:51:36
Message-ID: 847AA457BB9C49BD83A3BD0A0465F506@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

eFrom: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
> here is a prototype:

The patch applied and built with success. There are a few minor things:

(1)
help_variables() lacks description of some variables such as SINGLELINE and
SINGLESTEP. I think this help should list all available variables, because
users may want to know the existence of those missing variables. Based on
this, modify these lines: remove "some" from the first line and the entire
second line.

+ printf(_("List of some variables (options) for use from command
line.\n"));
+ printf(_("Complete list you find in psql section in the PostgreSQL
documentation.\n\n"));

(2)
The indent is different from other lines. Leave just two spaces at the
beginning of the line.

+ printf(_(" --help-variables list of available configuration
variables (options), then exit\n"));

(3)
This change is unnecessary. See src/bin/pg_dumpall.c for similar switches.

- while ((c = getopt_long(argc, argv,
"aAc:d:eEf:F:h:HlL:no:p:P:qR:sStT:U:v:VwWxXz?01",
or+ while ((c = getopt_long(argc, argv,
"aAc:d:eEf:F:h:HlL:no:p:P:qR:sStT:U:v:VwWxXz?001",

Regards
MauMau

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-06-21 17:22:31 review: tab completion for set search_path TO
Previous Message David Rowley 2014-06-21 12:03:18 Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses