| From: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Muhammad Usama'" <m(dot)usama(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Patch to compute Max LSN of Data Pages |
| Date: | 2013-01-18 13:22:24 |
| Message-ID: | 6C0B27F7206C9E4CA54AE035729E9C383BEB8A75@szxeml509-mbx |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Please find the rebased Patch for Compute MAX LSN.
There was one compilation error as "undefined reference to XLByteLT " as earlier XLogRecPtr was a structure as
typedef struct XLogRecPtr
{
uint32 xlogid; /* log file #, 0 based */
uint32 xrecoff; /* byte offset of location in log file */
} XLogRecPtr;
So in order to compare two LSN, there was one macro as XLByteLT to compare both fields.
But now XLogRecPtr has been changed as just uint64 and so XLByteLT is removed.
So the change done is to replace XLByteLT(*maxlsn, pagelsn) with (*maxlsn < pagelsn).
Muhammad, Can you verify if every thing is okay, then this can be marked as "Ready for Committer"
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_computemaxlsn_v5.patch | application/octet-stream | 26.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2013-01-18 13:24:54 | Re: Passing connection string to pg_basebackup |
| Previous Message | Stephen Frost | 2013-01-18 13:20:56 | Re: could not create directory "...": File exists |