| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: quoting psql varible as identifier |
| Date: | 2010-01-21 18:50:25 |
| Message-ID: | 603c8f071001211050h6daab7b1qfc03353ba60b4b32@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 21, 2010 at 12:53 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> add to state structure field like lexer_error. This field will be
> checked before execution
> it could be ugly for metacommands, there will be lot of new checks :(
Eh? The only places where we should need new tests are the places
that check PQExpBufferBroken() now - there are only 6 calls to that
function in src/bin/psql and not all of them need to be changed. The
places that do need to be changed will need to be modified to check
PQExpBufferBroken() || lexer_coughed_up_a_lung.
It should be possible to do this pretty simply, I think.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2010-01-21 19:00:12 | Re: [HACKERS] 8.5 vs. 9.0 |
| Previous Message | Robert Haas | 2010-01-21 18:32:45 | Re: About "Our CLUSTER implementation is pessimal" patch |