From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: quoting psql varible as identifier |
Date: | 2010-01-11 03:55:50 |
Message-ID: | 603c8f071001101955s44beed76lcbb69c10c606c9e9@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 5, 2010 at 8:23 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 2010/1/5 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> On Mon, Jan 4, 2010 at 2:51 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>> I don't have a problem to write second and safe fmtId
>>>> function (with technique used in dumputils don't need to modify
>>>> libpq), although fmtId do exactly what I need. I would to understand
>>>> to behave.
>>
>>> I think you mean that you would need to understand how it should
>>> behave - in which case I agree, but I think Tom spelled that out
>>> pretty clearly upthread: close PQescapeStringConn and adapt it to be
>>> PQescapeIdentifier.
>>
>> The more important point here is that fmtId doesn't do "exactly what you
>> need" in any case. fmtId is safe to use in pg_dump because pg_dump is
>> only expected to work with the same or older version of the backend.
>> It would not be safe to use it in libpq, which is expected to still work
>> with newer backends that might have more reserved words.
>
> So I finnaly moved to libpq PQescapeIdentConn function
>
> patch is attached.
No longer applies, please rebase.
Thanks,
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Sabino Mullane | 2010-01-11 04:05:55 | Re: Listen / Notify - what to do when the queue is full |
Previous Message | Robert Haas | 2010-01-11 03:13:32 | Re: damage control mode |