| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Filtering dictionaries support and unaccent dictionary |
| Date: | 2009-08-04 23:04:13 |
| Message-ID: | 603c8f070908041604p47eb1ae3lbf7f7fc78d8dbcea@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 1, 2009 at 12:35 AM, Alvaro
Herrera<alvherre(at)commandprompt(dot)com> wrote:
> Teodor Sigaev wrote:
>
>> >As for the contrib module, I think it could use a lot more function
>> >header comments! Also, it would be great if it could be used separately
>> >from tsearch, i.e. that it provided a function unaccent(text) returns
>> >text that unaccented arbitrary strings (I guess it would use the default
>> >tsconfig).
>> Umm? Module provides unaccent(text) and unaccent(regdictionary, text) functions.
>
> Sorry, I failed to notice. Looks good.
>
> Isn't that function leaking "res" pointer? Also, I'm curious why you're
> allocating 2*sizeof(TSLexeme) in unaccent_lexize ...
So are we waiting for an updated version of this patch?
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2009-08-04 23:04:20 | Re: SE-PostgreSQL Specifications |
| Previous Message | Kevin Grittner | 2009-08-04 22:38:04 | Re: the case for machine-readable error fields |