| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | shigeru(dot)hanada(at)gmail(dot)com, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: inherit support for foreign tables |
| Date: | 2014-10-16 07:39:37 |
| Message-ID: | 543F7639.300@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2014/08/28 18:00), Etsuro Fujita wrote:
> (2014/08/22 11:51), Noah Misch wrote:
>> Today's ANALYZE VERBOSE messaging for former inheritance parents
>> (tables with
>> relhassubclass = true but no pg_inherits.inhparent links) is
>> deceptive, and I
>> welcome a fix to omit the spurious message. As defects go, this is quite
>> minor. There's fundamentally no value in collecting inheritance tree
>> statistics for such a parent, and no PostgreSQL command will do so.
>> A
>> credible alternative is to emit a second message indicating that we
>> skipped
>> the inheritance tree statistics after all, and why we skipped them.
> I'd like to address this by emitting the second message as shown below:
> A separate patch (analyze.patch) handles the former case in a similar way.
I'll add to the upcoming CF, the analyze.patch as an independent item,
which emits a second message indicating that we skipped the inheritance
tree statistics and why we skipped them.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| analyze.patch | text/x-patch | 612 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-10-16 08:07:31 | Re: proposal: plpgsql - Assert statement |
| Previous Message | Andres Freund | 2014-10-16 07:11:34 | Re: WIP: dynahash replacement for buffer table |