Re: Unwanted LOG during recovery of DROP TABLESPACE REDO

From: Marko Tiikkaja <marko(at)joh(dot)to>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unwanted LOG during recovery of DROP TABLESPACE REDO
Date: 2014-08-15 09:31:24
Message-ID: 53EDD36C.5020409@joh.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/16/14 4:33 PM, Tom Lane wrote:
> Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> writes:
>> I found and fixed a bug that causes recovery (crash recovery , PITR) to throw unwanted LOG message if the tablespace symlink is not found during the processing of DROP TABLESPACE redo.
>> LOG: could not remove symbolic link "pg_tblspc/16384": No such file or directory
>
> I don't think that's a bug: it's the designed behavior. Why should we
> complicate the code to not print a log message in a situation where
> it's unclear if the case is expected or not?

I agree with Tom here; this doesn't seem like an improvement.

.marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2014-08-15 09:46:52 pgbench --tuple-size option
Previous Message Marko Tiikkaja 2014-08-15 08:55:04 Re: pgcrypto: PGP armor headers