Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>
Subject: Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors
Date: 2014-03-19 10:28:40
Message-ID: 53297158.1070503@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 19/03/14 09:45, Pavel Stehule wrote:
> Hello
>
> This patch introduce a possibility to implement some new checks without
> impact to current code.
>
> 1. there is a common agreement about this functionality, syntax, naming
>
> 2. patching is clean, compilation is without error and warning
>
> 3. all regress tests passed
>
> 4. feature is well documented
>
> 5. code is clean, documented and respect out codding standards
>
>
> Note: please, replace "shadowed-variables" by "shadowed_variables"
>
> This patch is ready for commit
>

Thanks! Attached new version of the patch with the above change.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
shadow_v5.patch text/x-patch 11.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-03-19 10:34:10 Re: Archive recovery won't be completed on some situation.
Previous Message Simon Riggs 2014-03-19 09:52:26 Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To: