From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Marko Tiikkaja <marko(at)joh(dot)to> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: new json funcs |
Date: | 2014-01-22 17:49:21 |
Message-ID: | 52E004A1.1070505@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 01/21/2014 06:21 PM, Marko Tiikkaja wrote:
> Hi Andrew,
>
> On 1/18/14, 10:05 PM, I wrote:
>> But I'll continue with my review now that this has been sorted out.
>
> Sorry about the delay.
>
> I think the API for the new functions looks good. They are all
> welcome additions to the JSON family.
>
> The implementation side looks reasonable to me. I'm not sure there's
> need to duplicate so much code, though. E.g. json_to_recordset is
> almost identical to json_populate_recordset, and json_to_record has a
> bit of the same disease.
>
> Finally, (as I'm sure you know already), docs are still missing.
> Marking the patch Waiting on Author for the time being.
>
>
>
New patch attached. Main change is I changed
json_populate_record/json_to_record to call a common worker function,
and likewise with json_populate_recordset/json_to_recordset.
We're still finalizing the docs - should be ready in the next day or so.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
newjsonfuncs-4.patch | text/x-patch | 43.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2014-01-22 17:54:28 | Re: WAL replay should fdatasync() segments? |
Previous Message | Josh Berkus | 2014-01-22 17:47:05 | Re: proposal: hide application_name from other users |