| From: | Antonin Houska <antonin(dot)houska(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Review: HStore Gin Speedup |
| Date: | 2013-11-18 22:59:21 |
| Message-ID: | 528A9BC9.3020202@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Following are my initial comments for
https://commitfest.postgresql.org/action/patch_view?id=1203
1. It no longer applies, probably due to commit
a18167510f4c385329697588ce5132cbf95779c3
error: contrib/hstore/hstore--1.1.sql: No such file or directory
2. Compatibility with HStore v2.0
(https://commitfest.postgresql.org/action/patch_view?id=1289)
As long as the separate operator class gin_hstore_combined_ops is used,
there should be no conflict. I'll verify as soon as the $subject patch
is applicable to master.
3. Regression tests
Shouldn't EXPLAIN be there too? I suggest a test that creates 2 indexes
on the hstore column - one using the existing GIN (default) opclass and
one using the new one (combined). The execution plan will then show if
an index is used and if it's the correct one.
// Antonin Houska (Tony)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Mlodgenski | 2013-11-18 23:47:10 | Re: Custom Scan APIs (Re: Custom Plan node) |
| Previous Message | Christophe Pettus | 2013-11-18 22:34:13 | Re: Data corruption issues using streaming replication on 9.0.14/9.2.5/9.3.1 |