| From: | Satoshi Nagayasu <snaga(at)uptime(dot)jp> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Greg Smith <greg(at)2ndQuadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PoC] pgstattuple2: block sampling to reduce physical read |
| Date: | 2013-09-16 04:20:52 |
| Message-ID: | 52368724.6050706@uptime.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2013/09/15 11:07), Peter Eisentraut wrote:
> On Sat, 2013-09-14 at 16:18 +0900, Satoshi Nagayasu wrote:
>> I'm looking forward to seeing more feedback on this approach,
>> in terms of design and performance improvement.
>> So, I have submitted this for the next CF.
>
> Your patch fails to build:
>
> pgstattuple.c: In function ‘pgstat_heap_sample’:
> pgstattuple.c:737:13: error: ‘SnapshotNow’ undeclared (first use in this function)
> pgstattuple.c:737:13: note: each undeclared identifier is reported only once for each function it appears in
Thanks for checking. Fixed to eliminate SnapshotNow.
Regards,
--
Satoshi Nagayasu <snaga(at)uptime(dot)jp>
Uptime Technologies, LLC. http://www.uptime.jp
| Attachment | Content-Type | Size |
|---|---|---|
| pgstattuple2_v2.diff | text/plain | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2013-09-16 04:32:11 | Re: [PATCH] bitmap indexes |
| Previous Message | Chris Travers | 2013-09-16 00:13:49 | Re: Proposal: json_populate_record and nested json objects |