| From: | Fabrízio de Royes Mello <fabrizio(at)timbira(dot)com(dot)br> |
|---|---|
| To: | Karol Trzcionka <karlikt(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements |
| Date: | 2013-07-26 00:44:09 |
| Message-ID: | 51F1C659.5040106@timbira.com.br |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24-07-2013 14:49, Karol Trzcionka wrote:
> Hello,
> patch works fine but is there any reason to comparing each ifNotExists
> in different way?
> i.e.
> ProcedureCreate
> if (!ifNotExists)
> ...
> else
> {
> ...
> return
> }
> ----
> TypeCreate
> if (ifNotExists)
> {
> ...
> return
> }
> ...
> ---
> Shouldn't it be more consistent?
Should be... I fix that in attached patch.
Regards,
--
Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
| Attachment | Content-Type | Size |
|---|---|---|
| create_if_not_exists_v3.patch | text/x-patch | 73.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2013-07-26 00:52:37 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |
| Previous Message | Robert Haas | 2013-07-25 23:53:01 | Re: Design proposal: fsync absorb linear slider |