| From: | Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Subject: | Re: pgsql_fdw, FDW for PostgreSQL server |
| Date: | 2012-04-07 01:32:33 |
| Message-ID: | 4F7F9931.2040900@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2012/04/07 1:38), Tom Lane wrote:
> Shigeru Hanada<shigeru(dot)hanada(at)gmail(dot)com> writes:
>> On Fri, Apr 6, 2012 at 11:20 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> In
>>> particular I do not like the specific way it's done in the v7 patch
>>> (I've not looked at v8 yet) because the interposed logic has a
>>> hard-wired assumption that foreign tables do not have inheritance
>>> children. I think that assumption has a life expectancy measured in
>>> months at most, and I don't want to have to try to fix every FDW when
>>> it changes. But I think we can easily revise the hook details to fix
>>> that, and I'm hoping to get that done today.
>
>> I'll try implementing the design you suggested.
>
> I've already got it fixed up ...
I've updated pgsql_fdw so that it can collect statistics from foreign
data with new FDW API.
Other changes from latest version are:
- Now pgsql_fdw uses libpq row processor API to get rid of SQL-level cursor.
- Introduced new struct ErrorPos to integrate error reporting in foreign
scan and analyze.
- Some refactoring, such as removing unnecessary parameter.
- Fix typos.
Regards,
--
Shigeru HANADA
| Attachment | Content-Type | Size |
|---|---|---|
| pgsql_fdw_v20.patch | text/plain | 108.4 KB |
| pgsql_fdw_pushdown_v13.patch | text/plain | 48.4 KB |
| pgsql_fdw_analyze_v2.patch | text/plain | 15.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jignesh Shah | 2012-04-07 03:20:06 | Re: patch: improve SLRU replacement algorithm |
| Previous Message | Shigeru Hanada | 2012-04-06 22:45:33 | Re: WIP: Collecting statistics on CSV file data |