| From: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
|---|---|
| To: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Cc: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Subject: | Re: pgsql_fdw, FDW for PostgreSQL server |
| Date: | 2012-03-06 12:37:20 |
| Message-ID: | 4F560500.8060006@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2012/03/06 19:09), Albe Laurenz wrote:
> I know this is not the latest version, but I played around with it and
> tickled a bug.
> It seems to have a problem with rolled back subtransactions.
Thanks for the report!
The problem was in cleanup_connection, which is called at end of
transactions. Connection should be closed only when the trigger is a
top level transaction and it's aborting, but isTopLevel flag was not
checked. I fixed the bug and added regression tests for such cases.
Attached patches also contains changes to catch up to the redesign of
PlanForeignScan.
Regards,
--
Shigeru Hanada
| Attachment | Content-Type | Size |
|---|---|---|
| pgsql_fdw_v13.patch | text/plain | 109.0 KB |
| pgsql_fdw_pushdown_v8.patch | text/plain | 31.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2012-03-06 12:52:09 | Re: Scaling XLog insertion (was Re: Moving more work outside WALInsertLock) |
| Previous Message | Shigeru Hanada | 2012-03-06 12:09:53 | Re: pgsql_fdw, FDW for PostgreSQL server |