| From: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> |
|---|---|
| To: | Marti Raudsepp <marti(at)juffo(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch review for logging hooks (CF 2012-01) |
| Date: | 2012-01-18 20:56:15 |
| Message-ID: | 4F1731EF.5020300@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/17/2012 11:40 PM, Marti Raudsepp wrote:
> It seems you missed a comment, that the current implementation is also
> affected by client_min_messages. I think that being affected by
> client-specific settings is surprising. I would put the
> if(emit_log_hook) inside the existing if(edata->output_to_server)
> condition. Unless you have some reason to do it this way?
>
I have no strong feelings about this -- if the behaviour seems
surprising, lets remove it. We need to keep the "if" separate
though -- the hook might want to omit the message from server
log so the "output_to_server" needs to be rechecked.
Updated patch attached.
regards,
Martin
| Attachment | Content-Type | Size |
|---|---|---|
| logging-hooks.patch | text/x-patch | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2012-01-18 21:18:34 | Re: Vacuum rate limit in KBps |
| Previous Message | Andres Freund | 2012-01-18 20:51:49 | Re: Command Triggers |