Re: contrib: auth_delay module

From: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>, Stephen Frost <sfrost(at)snowman(dot)net>, Jan Urbański <wulczer(at)wulczer(dot)org>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: contrib: auth_delay module
Date: 2010-11-25 06:18:38
Message-ID: 4CEDFFBE.6020702@ak.jp.nec.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2010/11/19 16:57), KaiGai Kohei wrote:
> (2010/11/18 2:17), Robert Haas wrote:
>> On Wed, Nov 17, 2010 at 10:32 AM, Ross J. Reedstrom<reedstrm(at)rice(dot)edu> wrote:
>>> On Tue, Nov 16, 2010 at 09:41:37PM -0500, Robert Haas wrote:
>>>> On Tue, Nov 16, 2010 at 8:15 PM, KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
>>>>> If we don't need a PoC module for each new hooks, I'm not strongly
>>>>> motivated to push it into contrib tree.
>>>>> How about your opinion?
>>>>
>>>> I'd say let it go, unless someone else feels strongly about it.
>>>
>>> I would use this module (rate limit new connection attempts) as soon as
>>> I could. Putting a cap on potential CPU usage on a production DB by either
>>> a blackhat or mistake by a developer caused by a mistake in
>>> configuration (leaving the port accessible) is definitely useful, even
>>> in the face of max_connections. My production apps already have
>>> their connections and seldom need new ones. They all use CPU though.
>>
>> If KaiGai updates the code per previous discussion, would you be
>> willing to take a crack at adding documentation?
>>
>> P.S. Your email client seems to be setting the Reply-To address to a
>> ridiculous value.
>>
> OK, I'll revise my patch according to the previous discussion.

The attached patch is revised version.

- Logging part within auth_delay was removed. This module now focuses on
injection of a few seconds delay on authentication failed.
- Documentation parts were added like any other contrib modules.

Thanks,
--
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment Content-Type Size
pgsql-v9.1-auth-delay.2.patch text/x-patch 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Tolley 2010-11-25 06:34:34 pg_execute_from_file review
Previous Message Itagaki Takahiro 2010-11-25 05:44:24 Re: Extensions, this time with a patch