Re: "serializable" in comments and names

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>, Robert Haas <robertmhaas(at)gmail(dot)com>, "<pgsql-hackers(at)postgresql(dot)org>" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "serializable" in comments and names
Date: 2010-09-09 16:11:31
Message-ID: 4C890733.6070602@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/08/2010 10:02 AM, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Tom Lane's message of mié sep 08 12:12:31 -0400 2010:
>>> AFAIR it doesn't keep the first snapshot around. If it did, most of
>>> your work on snapshot list trimming would have been useless, no?
>
>> That's my point precisely. The name "IsolationUsesXactSnapshot" makes
>> it sound like it applies to any transaction that uses snapshots for
>> isolation, doesn't it?
>
> I don't think so, at least not when compared to the alternative
> IsolationUsesStmtSnapshot.

The attached patch is updated for the various comments, as well as some
wording tweaks by me. If there are no objections I'd like to commit this
in a day or two.

Joe

--
Joe Conway
credativ LLC: http://www.credativ.us
Linux, PostgreSQL, and general Open Source
Training, Service, Consulting, & 24x7 Support

Attachment Content-Type Size
sernoop-v1.4.patch text/x-patch 19.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2010-09-09 16:12:12 Re: function_name.parameter_name
Previous Message David E. Wheeler 2010-09-09 15:58:25 Re: returning multiple result sets from a stored procedure