From: | Mike Fowler <mike(at)mlfowler(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Re: Adding XMLEXISTS to the grammar |
Date: | 2010-06-29 11:22:06 |
Message-ID: | 4C29D75E.8050607@mlfowler.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mike Fowler wrote:
> Thanks again for your help Robert, turns out the fault was in the
> pg_proc entry (the 3 up there should've been a two!). Once I took the
> grammar out it was quickly obvious where I'd gone wrong.
>
> Attached is a patch with the revised XMLEXISTS function, complete with
> grammar support and regression tests. The implemented grammar is:
>
> XMLEXISTS ( xpath_expression PASSING BY REF xml_value [BY REF] )
>
> Though the full grammar makes everything after the xpath_expression
> optional, I've left it has mandatory simply to avoid lots of rework of
> the function (would need new null checks, memory handling would need
> reworking).
>
As with the xpath_exists patch I've now added the SGML documentation
detailing this function and extended the regression test a little to
test XML literals.
Regards,
--
Mike Fowler
Registered Linux user: 379787
Attachment | Content-Type | Size |
---|---|---|
xmlexists-5.patch | text/x-diff | 16.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-06-29 13:33:20 | Re: warning message in standby |
Previous Message | Robert Haas | 2010-06-29 10:59:39 | Re: warning message in standby |