| From: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review of Writeable CTE Patch |
| Date: | 2010-02-03 23:03:59 |
| Message-ID: | 4B6A00DF.1030006@cs.helsinki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached is an updated patch. I'm now going to start working on the
documentation and I'll send it in a separate patch a bit later.
On 2010-02-03 16:53 UTC+2, Robert Haas wrote:
> Some thoughts:
> This patch
> removes a number of other assertions as well, but I don't know enough
> about those other spots to judge whether all of those cases are
> sensible.
I put back the Asserts in make_modifytable(). The one in
ExecInitModifyTable() is not true any more and neither is the Assert in
transformInsertStatement().
Regards,
Marko Tiikkaja
| Attachment | Content-Type | Size |
|---|---|---|
| dmlwith8.patch | text/plain | 67.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-02-03 23:41:43 | Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH] |
| Previous Message | Andrew Dunstan | 2010-02-03 22:57:01 | Re: PG 9.0 and standard_conforming_strings |